Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish flask restx migration #3205

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

nikromen
Copy link
Member

@nikromen nikromen commented Apr 8, 2024

review this after #3168

Fixes #2809, fixes #2997

#2809 has some optional issues but the main migration is done so I think we can close the epic and keep those optional as individuals

@nikromen nikromen force-pushed the finish-flask-restx-migration branch 4 times, most recently from da7e653 to 64bef8c Compare April 14, 2024 16:04
@nikromen nikromen force-pushed the finish-flask-restx-migration branch from 64bef8c to 900b918 Compare April 14, 2024 16:11
@FrostyX FrostyX self-requested a review April 15, 2024 10:48
Copy link
Member

@FrostyX FrostyX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, thank you:-)

@FrostyX
Copy link
Member

FrostyX commented Apr 18, 2024

The only shameful skeleton in the closet that remains is the mess in docs.py, fields.py, and schemas.py.
We should probably do some brainstorming about it. But that's a thing for a separate PR.

@nikromen nikromen force-pushed the finish-flask-restx-migration branch from 900b918 to 26a6223 Compare April 19, 2024 11:31
@nikromen nikromen merged commit 9af3a8c into fedora-copr:main Apr 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate api_v3/builds to flask-restx Migrate API to flask-restx
2 participants