-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish flask restx migration #3205
Merged
nikromen
merged 2 commits into
fedora-copr:main
from
nikromen:finish-flask-restx-migration
Apr 19, 2024
Merged
Finish flask restx migration #3205
nikromen
merged 2 commits into
fedora-copr:main
from
nikromen:finish-flask-restx-migration
Apr 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikromen
force-pushed
the
finish-flask-restx-migration
branch
4 times, most recently
from
April 14, 2024 16:04
da7e653
to
64bef8c
Compare
nikromen
force-pushed
the
finish-flask-restx-migration
branch
from
April 14, 2024 16:11
64bef8c
to
900b918
Compare
FrostyX
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM, thank you:-)
The only shameful skeleton in the closet that remains is the mess in |
nikromen
force-pushed
the
finish-flask-restx-migration
branch
from
April 19, 2024 11:31
900b918
to
26a6223
Compare
FrostyX
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review this after #3168
Fixes #2809, fixes #2997
#2809 has some optional issues but the main migration is done so I think we can close the epic and keep those optional as individuals