Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixture instead of deprecated yield_fixture #3364

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

FrostyX
Copy link
Member

@FrostyX FrostyX commented Aug 10, 2024

Fix #3351

The deprecation warning even says "Use @pytest.fixture instead; they are the same".

@FrostyX
Copy link
Member Author

FrostyX commented Aug 10, 2024

The CI failure is unrelated to this PR but it is caused by #3365.
But to be sure, let's wait until it's green.

Copy link
Member

@nikromen nikromen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems straightforward but yup, let's wait for the CI to be green before merging

@FrostyX FrostyX force-pushed the deprecated-yield-fixture branch 3 times, most recently from 6b5c33b to 690bf70 Compare August 23, 2024 18:29
cli/tests/cli_tests_lib.py Fixed Show fixed Hide fixed
cli/tests/cli_tests_lib.py Fixed Show fixed Hide fixed
…eld_fixture

Fix fedora-copr#3351

The deprecation warning even says "Use @pytest.fixture instead; they
are the same".
@FrostyX
Copy link
Member Author

FrostyX commented Aug 23, 2024

CI fixed, PTAL.

@xsuchy xsuchy merged commit b53eaf3 into fedora-copr:main Aug 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backend: @pytest.yield_fixture is deprecated.
3 participants