Point Copr repositories to Pulp #3383
Open
+55
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I submitted this only as a draft because there was an issue with installing packages from the repositories (even though DNF was able to sync the repository metadata). It turned out to be a bug in Pulp code - pulp/pulp_rpm#3719 I think there is no need to wait until it is fixed, this PR is ready for review. |
|
Please cover dnf5 copr enable use-case, too |
FrostyX
force-pushed
the
pulp-repos
branch
2 times, most recently
from
9d21a77
to
e12fe16
Compare
Fix fedora-copr#3375 Of course only for Copr projects that has configured to have their storage in Pulp, not all Copr projects. There are three possible options how to implement this. 1. The Most straightforward is to not generate repofiles ourselves and let Pulp do it. The downside is that we would have to pass additional parameters (it is possible though) such as repo priority, module hotfixes attribute, etc, and figure out how to count repo downloads 2. Generate repofiles ourselves, only point to `baseurl` in Pulp. This IMHO the best option for keeping compatibility between storage on the backend and in Pulp, so I implement this option in this PR. 3. Adding a Lighttpd redirect for `baseurl` of the Pulp-stored projects to Pulp content URL. This will be needed in the future to ensure that users don't have to re-enable Copr repositories, once those projects are migrated to Pulp. But this will be hard to implement, so we decided to do it when the time comes.
|
Updated PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3375
Of course only for Copr projects that has configured to have their storage in Pulp, not all Copr projects.
There are three possible options how to implement this.
do it. The downside is that we would have to pass additional parameters (it
is possible though) such as repo priority, module hotfixes attribute, etc,
and figure out how to count repo downloads
baseurlin Pulp. This IMHO thebest option for keeping compatibility between storage on the backend and in
Pulp, so I implement this option in this PR.
baseurlof the Pulp-stored projects to Pulpcontent URL. This will be needed in the future to ensure that users don't
have to re-enable Copr repositories, once those projects are migrated to
Pulp. But this will be hard to implement, so we decided to do it when the
time comes.