Don't upload RPM packages to Pulp as artifacts #3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pulp/pulp_rpm#3719 Instead of uploading RPM packages as artifacts in one API call, and then creating a content from them in a separate call, we will now create the content directly. There are mutiple reasons to do so: - One API call instead of two - It fixes the issue with installing packages mentioned above - @dkliban says there is an effort to not allow uploading artifacts on shared Pulp instances There is only one disadvantage of doing this, we lose track of what RPM packages belong to a specific Copr build ID. We will use labels for this, once they are implemented. See pulp/pulpcore#3338 (comment)
praiskup
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pulp/pulp_rpm#3719
Instead of uploading RPM packages as artifacts in one API call, and then creating a content from them in a separate call, we will now create the content directly.
There are mutiple reasons to do so:
There is only one disadvantage of doing this, we lose track of what RPM packages belong to a specific Copr build ID. We will use labels for this, once they are implemented.
See pulp/pulpcore#3338 (comment)