frontend: fix the 500 for racy creation attempts #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
praiskup
force-pushed
the
praiskup-packit-500
branch
from
b7cee48
to
9f5476d
Compare
This is TOCTOU issue. The other checks for duplications (on so many places) seem kinda redundant because nothing but try/except for commit() may catch these concurrency problems. Fixes: fedora-copr#3372
praiskup
force-pushed
the
praiskup-packit-500
branch
from
9f5476d
to
f0dd449
Compare
nikromen
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is TOCTOU issue. The other checks for duplications (on so many places) seem kinda redundant because nothing but try/except for commit() may catch these concurrency problems.
Fixes: #3372