backend: unknown resalloc tickets helper cleanup #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
praiskup
force-pushed
the
praiskup-ticket-checker
branch
from
d25c5de
to
cf0fd3c
Compare
FrostyX
reviewed
Sep 23, 2024
| @@ -33,7 +33,9 @@ def used_ids(): | |||
| output = output.strip() | |||
| tickets = set() | |||
| for ticket_id in output.split("\n"): | |||
| assert all(c.isdigit() for c in ticket_id) | |||
| if len(ticket_id) <= 0: | |||
There was a problem hiding this comment.
This needs an explanation. A length of a string ticket ID, is a weird thing to calculate. Are you basically doing if ticket_id:?
If no tickets are taken (which often happens in the staging environment), this script encountered corner case issues.
praiskup
force-pushed
the
praiskup-ticket-checker
branch
from
cf0fd3c
to
8353581
Compare
FrostyX
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no tickets are taken (which often happens in the staging environment), this script encountered corner case issues.