-
Notifications
You must be signed in to change notification settings - Fork 197
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Automated Tests table rows for absent and error results
This fixes my own oversight from #5480 . In changing the signature of make_row there, I did not remember to update all these other calls to it. This means make_row goes a bit crazy trying to treat 'FAILED' or 'ABSENT' as a subject and an error string or empty string as the outcome, and winds up rendering what looks to the user like an empty row. This should fix it so we actually get rows with sensible content again when a result is absent or there's some kind of remote rule error. Thanks to @decathorpe for finding this. Signed-off-by: Adam Williamson <[email protected]> (cherry picked from commit 960945f)
- Loading branch information
1 parent
790be5e
commit 137c402
Showing
2 changed files
with
17 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Fixed Automated Tests table in the web UI not showing missing results or remote rule errors correctly |