Container flatpak detection (backport #5496) #5498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The image specific extra data is canonically inside the 'typeinfo' dictionary. Koji has mirrored one to the other for koji-containerbuild builds for a long time. See, e.g.: https://koji.fedoraproject.org/koji/buildinfo?buildID=1530154 From June 2020. (This seems to be the first with the mirroring.) Signed-off-by: Owen W. Taylor <[email protected]> (cherry picked from commit 05ff7e3)
Instead of looking for container_koji_task_id in the build extra, look for typeinfo.image. If we see typeinfo.image without pull specs (e.g., an ISO image), error out cleanly up front. Previously the code would assume an RPM update if you passed it the build NVR of an ISO image. Signed-off-by: Owen W. Taylor <[email protected]> (cherry picked from commit b32286e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #5496 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com