Automated tests: display openQA 'machine' rather than arch #5533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the little lozenges we show on the Automated Tests tab rows to differentiate multiple runs of the same test case, currently we show 'arch' and 'flavor' for openQA tests. However, this doesn't sufficiently distinguish some tests: e.g. install_default_update_netinst, which is run on both BIOS and UEFI on x86_64. Both of these are listed as "x86_64 everything-boot-iso" at present. This makes us display the openQA "machine" instead of the arch, if we can determine it (from the scenario). As "machine" will always be more distinguishing than "arch" when present, we don't show "arch" if we can find "machine". This will make the two install_default_update_netinst runs show as "64bit everything-boot-iso" and "uefi everything-boot-iso". Other tests will also now show "64bit" (the x86_64 BIOS 'machine' name in openQA) rather than "x86_64", which might be a bit more confusing I guess; if that's a problem, we can consider changing the machine names in openQA to something clearer like "x86_64-uefi" and "x86_64-bios" or something, I'd just have to think about what other things might need changing in that case. Signed-off-by: Adam Williamson <[email protected]>
mattiaverga
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the little lozenges we show on the Automated Tests tab rows to differentiate multiple runs of the same test case, currently we show 'arch' and 'flavor' for openQA tests. However, this doesn't sufficiently distinguish some tests: e.g.
install_default_update_netinst, which is run on both BIOS and UEFI on x86_64. Both of these are listed as
"x86_64 everything-boot-iso" at present.
This makes us display the openQA "machine" instead of the arch, if we can determine it (from the scenario). As "machine" will always be more distinguishing than "arch" when present, we don't show "arch" if we can find "machine".
This will make the two install_default_update_netinst runs show as "64bit everything-boot-iso" and "uefi everything-boot-iso". Other tests will also now show "64bit" (the x86_64 BIOS 'machine' name in openQA) rather than "x86_64", which might be a bit more confusing I guess; if that's a problem, we can consider changing the machine names in openQA to something clearer like "x86_64-uefi" and "x86_64-bios" or something, I'd just have to think about what other things might need changing in that case.