Adjust to backwards-incompatible changes in aiosmtplib 3.x

Signed-off-by: Aurélien Bompard <[email protected]>
fedora-infra · Dec 8, 2023 · 718487e · 718487e
1 parent 15cde4a
commit 718487e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/changelog.d/+aiosmtplib-3.fixed.md b/changelog.d/+aiosmtplib-3.fixed.md
@@ -0,0 +1 @@
+Adjust to backwards-incompatible changes in aiosmtplib 3.x
diff --git a/fmn/sender/email.py b/fmn/sender/email.py
@@ -15,7 +15,8 @@
 class EmailHandler(Handler):
     async def setup(self):
         self._smtp = SMTP(
-            self._config.get("smtp_host", "localhost"), self._config.get("smtp_port", 25)
+            hostname=self._config.get("smtp_host", "localhost"),
+            port=self._config.get("smtp_port", 25),
         )
         await self._smtp.connect()
 

diff --git a/tests/sender/test_email.py b/tests/sender/test_email.py
@@ -16,7 +16,7 @@ async def test_email_connect(mocker):
 
     await handler.setup()
 
-    smtp_class.assert_called_once_with("smtp.example.com", 487)
+    smtp_class.assert_called_once_with(hostname="smtp.example.com", port=487)
     smtp.connect.assert_called_once_with()
 
     await handler.stop()
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Adjust to backwards-incompatible changes in aiosmtplib 3.x