Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change packaging to not require default health check scripts #117

Closed
miabbott opened this issue Sep 22, 2023 · 7 comments
Closed

change packaging to not require default health check scripts #117

miabbott opened this issue Sep 22, 2023 · 7 comments
Labels
jira flow issues to jira

Comments

@miabbott
Copy link
Member

The currently available default health check scripts which are required do not have the level of reliability we desire for Edge device scenarios.

See #68, #71, #90, #93, #98 for examples of difficulties, failures, etc of the scripts

Until we are able to provide more resilient health checks by default, we should package the existing scripts in a separate RPM and have it be an optional install.

@say-paul say-paul added enhancement New feature or request question Further information is requested and removed enhancement New feature or request labels Sep 22, 2023
@say-paul
Copy link
Member

say-paul commented Sep 25, 2023

The health-check is distributed as separate package.
But installed by default via image-builder for r4e

@miabbott
Copy link
Member Author

But installed by default via image-builder for r4e

Thanks for pointing that out; I'd say we should stop including the subpackage by default in Fedora IoT/R4E until we have more confidence in health checks.

@say-paul
Copy link
Member

PR: osbuild/images#179

@7flying
Copy link
Member

7flying commented Sep 28, 2023

I might have understood yesterday's discussion differently, I thought that we were going to leave the default health checks as they are, since internet connectivity is usually part of the critical path, and we were going to think about how to implement #119 , so I don't think that we should do osbuild/images#179

@say-paul
Copy link
Member

say-paul commented Sep 28, 2023

Yes, We would be looking for options to make it configurable, I would still keep the PR until we decide how to package the default-health-check if we want configure it from greenboot.

@7flying
Copy link
Member

7flying commented Sep 28, 2023

Ideas:

  • We agree that we should not remove the default checks RPM.
  • We should configure the checks two ways: is it enabled/disabled (use a list for this), and is it required or wanted (in case that it is enabled).
  • We are going to use a single config file instead of using directories to express configuration.

Other things to consider:

  • How are we going to handle "old" greenboot versions that still have the required.d and wanted.d ?
  • How are we going to handle config upgrades with new health checks?
  • How are we going to handle health checks provided by the user?

Future:

  • Allow overriding "default" config file if another file is found at X directory.

@say-paul say-paul added jira flow issues to jira and removed question Further information is requested labels Oct 10, 2023
@say-paul
Copy link
Member

addressed with #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira flow issues to jira
Projects
None yet
Development

No branches or pull requests

3 participants