Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide mechanism for disabling certain default health checks #119

Closed
miabbott opened this issue Sep 27, 2023 · 1 comment · Fixed by #137
Closed

provide mechanism for disabling certain default health checks #119

miabbott opened this issue Sep 27, 2023 · 1 comment · Fixed by #137
Labels
jira flow issues to jira

Comments

@miabbott
Copy link
Member

The opinion around #117 is that removal of the health checks is too coarse and severely limits the usefulness of greenboot as a whole.

Instead, let's investigate a means of enabling/disabling the default health checks.
@7flying 7flying mentioned this issue Sep 28, 2023
Closed
@runcom runcom added the jira flow issues to jira label Feb 8, 2024
@7flying
Copy link
Member

7flying commented Mar 19, 2024

  • we need to give the user the ability to choose whether they want the default health checks enabled or not (all of them, some of them etc), given that they may have the default-health-checks RPM installed

djach7 added a commit to djach7/greenboot that referenced this issue Apr 3, 2024
@djach7
greenboot: add feature to disable healthchecks
6d03294 
Addresses fedora-iot#119. Allows users to specify healthchecks
to be skipped via a DISABLED_HEALTHCHECKS variable
in greenboot.conf. Skipped healthchecks will be
reflected with an appropriate message in the logs.

Signed-off-by: djach7 <[email protected]>
@djach7 djach7 mentioned this issue Apr 3, 2024
Merged
@djach7 djach7 linked a pull request Apr 3, 2024 that will close this issue
greenboot: add feature to disable healthchecks #137
Merged
djach7 added a commit to djach7/greenboot that referenced this issue Apr 5, 2024
@djach7
greenboot: add feature to disable healthchecks
8f50aba 
Addresses fedora-iot#119. Allows users to specify healthchecks
to be skipped via a DISABLED_HEALTHCHECKS variable
in greenboot.conf. Skipped healthchecks will be
reflected with an appropriate message in the logs.

Signed-off-by: djach7 <[email protected]>
djach7 added a commit to djach7/greenboot that referenced this issue Apr 5, 2024
@djach7
greenboot: add feature to disable healthchecks
425c8b3 
Addresses fedora-iot#119. Allows users to specify healthchecks
to be skipped via a DISABLED_HEALTHCHECKS variable
in greenboot.conf. Skipped healthchecks will be
reflected with an appropriate message in the logs.

Signed-off-by: djach7 <[email protected]>
djach7 added a commit to djach7/greenboot that referenced this issue Apr 5, 2024
@djach7
greenboot: add feature to disable healthchecks
f51b92f 
Addresses fedora-iot#119. Allows users to specify healthchecks
to be skipped via a DISABLED_HEALTHCHECKS variable
in greenboot.conf. Skipped healthchecks will be
reflected with an appropriate message in the logs.

Signed-off-by: djach7 <[email protected]>
@BreiteSeite BreiteSeite mentioned this issue Apr 8, 2024
Open
djach7 added a commit to djach7/greenboot that referenced this issue Apr 9, 2024
@djach7
greenboot: add feature to disable healthchecks
b48fe43 
Addresses fedora-iot#119. Allows users to specify healthchecks
to be skipped via a DISABLED_HEALTHCHECKS variable
in greenboot.conf. Skipped healthchecks will be
reflected with an appropriate message in the logs.

Signed-off-by: djach7 <[email protected]>
djach7 added a commit to djach7/greenboot that referenced this issue Apr 9, 2024
@djach7
greenboot: add feature to disable healthchecks
c4ef2af 
Addresses fedora-iot#119. Allows users to specify healthchecks
to be skipped via a DISABLED_HEALTHCHECKS variable
in greenboot.conf. Skipped healthchecks will be
reflected with an appropriate message in the logs.

Signed-off-by: djach7 <[email protected]>
djach7 added a commit to djach7/greenboot that referenced this issue Apr 9, 2024
@djach7
greenboot: add feature to disable healthchecks
6cc439e 
Addresses fedora-iot#119. Allows users to specify healthchecks
to be skipped via a DISABLED_HEALTHCHECKS variable
in greenboot.conf. Skipped healthchecks will be
reflected with an appropriate message in the logs.

Signed-off-by: djach7 <[email protected]>
djach7 added a commit to djach7/greenboot that referenced this issue Apr 9, 2024
@djach7
greenboot: add feature to disable healthchecks
b57893d 
Addresses fedora-iot#119. Allows users to specify healthchecks
to be skipped via a DISABLED_HEALTHCHECKS variable
in greenboot.conf. Skipped healthchecks will be
reflected with an appropriate message in the logs.

Signed-off-by: djach7 <[email protected]>
djach7 added a commit to djach7/greenboot that referenced this issue Apr 9, 2024
@djach7
greenboot: add feature to disable healthchecks
f560ceb 
Addresses fedora-iot#119. Allows users to specify healthchecks
to be skipped via a DISABLED_HEALTHCHECKS variable
in greenboot.conf. Skipped healthchecks will be
reflected with an appropriate message in the logs.

Signed-off-by: djach7 <[email protected]>
djach7 added a commit to djach7/greenboot that referenced this issue Apr 10, 2024
@djach7
greenboot: add feature to disable healthchecks
3948dbd 
Addresses fedora-iot#119. Allows users to specify healthchecks
to be skipped via a DISABLED_HEALTHCHECKS variable
in greenboot.conf. Skipped healthchecks will be
reflected with an appropriate message in the logs.

Signed-off-by: djach7 <[email protected]>
djach7 added a commit to djach7/greenboot that referenced this issue Apr 11, 2024
@djach7
greenboot: add feature to disable healthchecks
7ee94c8 
Addresses fedora-iot#119. Allows users to specify healthchecks
to be skipped via a DISABLED_HEALTHCHECKS variable
in greenboot.conf. Skipped healthchecks will be
reflected with an appropriate message in the logs.

Signed-off-by: djach7 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
jira flow issues to jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

greenboot: add feature to disable healthchecks djach7/greenboot
3 participants
@runcom @7flying @miabbott