Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The /etc/greenboot/greenboot.conf file is overwritten when upgrading / downgrading the package #142

Closed
ggiguash opened this issue Jun 18, 2024 · 6 comments
Assignees

Comments

@ggiguash
Copy link

The /etc/greenboot/greenboot.conf file is overwritten when upgrading / downgrading the package.
This prevents from user customizations to persist following an OS upgrade.

  1. sudo dnf downgrade -y greenboot
  2. Edit or create /etc/greenboot/greenboot.conf
# grep -vE '^$|^#' /etc/greenboot/greenboot.conf 
GREENBOOT_MAX_BOOT_ATTEMPTS=1
GREENBOOT_WATCHDOG_CHECK_ENABLED=true
  1. sudo dnf upgrade -y greenboot
  2. Check the file contents
# grep -vE '^$|^#' /etc/greenboot/greenboot.conf 
GREENBOOT_WATCHDOG_CHECK_ENABLED=true
@nullr0ute nullr0ute self-assigned this Jun 18, 2024
@nullr0ute
Copy link
Member

Good catch, we need to label that as a config so it doesn't do that. Will have a fix shortly.

@nullr0ute
Copy link
Member

This should be fixed with this update: https://bodhi.fedoraproject.org/updates/FEDORA-2024-db58423740

I've tagged it so it'll appear in the next F-40 compose.

@ggiguash
Copy link
Author

Thank you, @nullr0ute, for the quick fix!

@miabbott
Copy link
Member

@nullr0ute
Copy link
Member

I was curious about the commit, so here you go - https://src.fedoraproject.org/rpms/greenboot/c/8e29d4027242c0ffbf1007963ae84b92c278fb74?branch=rawhide

This was the main fix, I did some other cleanup:

  •        %{_sysconfdir}/%{name}/greenboot.conf
    
  •        %config(noreplace) %{_sysconfdir}/%{name}/greenboot.conf
    

@say-paul
Copy link
Member

Closing this as the issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants