Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-3503: Properly apply greenboot timeout increase in blueprints and container files #3615

Merged
merged 1 commit into from
Jul 11, 2024
Merged

USHIFT-3503: Properly apply greenboot timeout increase in blueprints and container files #3615

merged 1 commit into from
Jul 11, 2024

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Jul 10, 2024 •
edited
Loading

The greenboot RPM released in RHEL 9.x OS overwrites the /etc/greenboot/greenboot.conf customizations (see fedora-iot/greenboot#142).

Work around this issue by:

  • ostree: include the customization in blueprints
  • bootc: include the customization in containerfiles
  • rpm: apply the customization after installing MicroShift (and greenboot) RPMs

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 10, 2024 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-3503 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

The greenboot RPM released in RHEL 9.x OS overwrites the /etc/greenboot/greenboot.conf customizations (see fedora-iot/greenboot#142).

Work around this issue by:

  • ostree: include the customization in blueprints
  • bootc: include the customization in containerfile
  • rpm: apply the customization after installing MicroShift (and greenboot) RPMs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@ggiguash ggiguash marked this pull request as ready for review July 10, 2024 08:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 10, 2024 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-3503 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

The greenboot RPM released in RHEL 9.x OS overwrites the /etc/greenboot/greenboot.conf customizations (see fedora-iot/greenboot#142).

Work around this issue by:

  • ostree: include the customization in blueprints
  • bootc: include the customization in containerfiles
  • rpm: apply the customization after installing MicroShift (and greenboot) RPMs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@ggiguash: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test ocp-full-conformance-rhel-eus
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor Author

/test metal-bootc-test
/test metal-bootc-test-arm
/test metal-periodic-test
/test metal-periodic-test-arm

@ggiguash
Copy link
Contributor Author

/test microshift-metal-cache
/test microshift-metal-cache-arm

@ggiguash
Copy link
Contributor Author

/test microshift-metal-cache
/test microshift-metal-cache-arm
/test metal-bootc-test
/test metal-bootc-test-arm
/test metal-periodic-test
/test metal-periodic-test-arm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ggiguash ggiguash mentioned this pull request Jul 10, 2024
Merged
@pmtk
Copy link
Member

pmtk commented Jul 11, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4b5654f into openshift:main Jul 11, 2024
12 checks passed
@ggiguash ggiguash deleted the greenboot_fix branch July 12, 2024 05:33
@ggiguash ggiguash mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@pacevedom pacevedom Awaiting requested review from pacevedom

Assignees

@pmtk pmtk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggiguash @openshift-ci-robot @pmtk