Invoke commands by Makefile
#122
Conversation
Signed-off-by: priyapahwa <[email protected]>
| <a href="https://github.com/fedora-iot/zezere/issues"> | ||
| <img alt="Issues" src="https://img.shields.io/github/issues/fedora-iot/zezere.svg?style=for-the-badge" style="max-width:100%;"> | ||
| </a> | ||
| </p> |
There was a problem hiding this comment.
any reason for not using markdown specifically? 🤔
There was a problem hiding this comment.
Using regular HTML tags comes in handy while specifying the dimensions of an image. Rest, nothing specific.
| django>=2.1 | ||
| djangorestframework | ||
| mod_wsgi-standalone | ||
| psycopg2-binary |
There was a problem hiding this comment.
I was going by the common convention to put testing or development requirements in a separate file. The basic idea behind this was to install all developmental dependencies by invoking make commands in that respective directory.
| @@ -0,0 +1,43 @@ | |||
| PYTHON_EXE?=python3 | |||
There was a problem hiding this comment.
Any reason you're using Makefile for this?
There was a problem hiding this comment.
Facing issues while setting up a project is quite inevitable. To simplify the process, make commands might be invoked after specifying the tasks to be executed.
The sole purpose was to set the desired python version in the makefile. In my opinion, they make the Makefile cleaner and can be overridden by the user as per the future requirements.
| @@ -0,0 +1,4 @@ | |||
| django>=2.1 | |||
There was a problem hiding this comment.
Why create a separate requirements file and not use the project-level one?
This will likely get out of sync.
There was a problem hiding this comment.
We can use the project-level requirements file for sure. No doubt that right now it does not serve any major purpose but as the size of the source code grows with the passage of time, specifying separate dependencies for production and development seems more reasonable. Moreover, in the case of working with unit testing frameworks, installing that in production would be unavailing.
This PR closes #108 by including:
Makecommands for setup and usageSigned-off-by: priyapahwa [email protected]