Skip to content

Commit

Permalink
Revert "Show error results expanded by default one level down"
Browse files Browse the repository at this point in the history
This would show all errors expanded which clutters the issue too much
IMHO.

This reverts commit 38b7fa5.
  • Loading branch information
kwk committed Aug 21, 2024
1 parent d5bf84d commit e488fdf
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion snapshot_manager/snapshot_manager/build_status.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def render_as_markdown(self) -> str:
if self.url_build_log is None:
link = f'<a href="{self.build_page_url}">build page</a>'
return f"""
<details open>
<details>
<summary>
<code>{self.package_name}</code> on <code>{self.chroot}</code> (see {link})
</summary>
Expand Down
14 changes: 7 additions & 7 deletions snapshot_manager/tests/build_status_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def test_render_as_markdown(self):
)

expected = """
<details open>
<details>
<summary>
<code>foo</code> on <code>fedora-40-x86_64</code> (see <a href="https://example.com/url_build_log">build log</a>, <a href="https://logdetective.com/contribute/copr/00001234/fedora-40-x86_64">contribute to log-detective</a>)
</summary>
Expand Down Expand Up @@ -152,42 +152,42 @@ def test_render_as_markdown(self):
actual = build_status.render_as_markdown(unsorted)

expected = """<ul><li><b>network_issue</b><ol><li>
<details open>
<details>
<summary>
<code>package-a</code> on <code>chroot-a</code> (see <a href="http://e1">build log</a>, <a href="https://logdetective.com/contribute/copr/00000111/chroot-a">contribute to log-detective</a>)
</summary>
e1
</details>
</li><li>
<details open>
<details>
<summary>
<code>package-b</code> on <code>chroot-a</code> (see <a href="http://e2">build log</a>, <a href="https://logdetective.com/contribute/copr/00000222/chroot-a">contribute to log-detective</a>)
</summary>
e2
</details>
</li><li>
<details open>
<details>
<summary>
<code>package-c</code> on <code>chroot-a</code> (see <a href="http://e3">build log</a>, <a href="https://logdetective.com/contribute/copr/00000333/chroot-a">contribute to log-detective</a>)
</summary>
e3
</details>
</li></ol></li><li><b>test</b><ol><li>
<details open>
<details>
<summary>
<code>package-a</code> on <code>chroot-c</code> (see <a href="http://e4">build log</a>, <a href="https://logdetective.com/contribute/copr/00000444/chroot-c">contribute to log-detective</a>)
</summary>
e4
</details>
</li><li>
<details open>
<details>
<summary>
<code>package-b</code> on <code>chroot-c</code> (see <a href="http://e5">build log</a>, <a href="https://logdetective.com/contribute/copr/00000555/chroot-c">contribute to log-detective</a>)
</summary>
e5
</details>
</li><li>
<details open>
<details>
<summary>
<code>package-c</code> on <code>chroot-c</code> (see <a href="http://e6">build log</a>, <a href="https://logdetective.com/contribute/copr/00000666/chroot-c">contribute to log-detective</a>)
</summary>
Expand Down

0 comments on commit e488fdf

Please sign in to comment.