Add script to compare package contents #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
previously approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Thanks, works great!
I've reviewed the results, and found the following differences:
- clang-libs ships way too many libraries. Fixed in https://src.fedoraproject.org/rpms/llvm/pull-request/241.
- rawhide ships the clang cfg files in clang-libs, while big-merge ships them in clang. I think the big-merge behavior is correct, but maybe I'm missing some subtlety with library users of clang here. @tstellar Do you know why these config files were in clang-libs?
- python3-clang in big-merge is just an empty directory! Something is wrong here.
|
https://src.fedoraproject.org/rpms/llvm/pull-request/242 is the fix for the python-clang issue. |
Co-authored-by: Nikita Popov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script checks the actual package contents of rawhide and the currently promoted snapshot build. It uses the systems architecture in order to run two containers with the right set of LLVM versions installed.