Fix copr packages not installed in Fedora 41 and newer #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 28, 2024 08:01
Add a prepare step that checks the version of installed llvm-libs to ensure it's a copr package.
Followup fedora-llvm-team#670. Reimplement without using a specific dnf. Replace the unexpanded $distname variable in the script
Before trying to modify the repo we check that it exists, hence we no longer need to mask the result of commands. This now works with both dnf4 and dnf5 Fixes fedora-llvm-team#671
kwk
approved these changes
Aug 28, 2024
| - name: "Check that snapshot (~pre) version of LLVM is installed" | ||
| how: shell | ||
| order: 99 | ||
| script: rpm -q --qf "%{version}" llvm-libs | grep '~pre' |
There was a problem hiding this comment.
This is neat! Nice improvement to use the query format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes package installation issues in tmt runs due to dnf5 incompatibilities. Changes introduced:
llvm-libsis a snapshots package coming from copr (~preversion)testing-farm-tag-repositorypriority is handled. Before trying to modify the repo we check that it exists, hence we no longer need to mask the result of commands. This now works with both dnf4 and dnf5Tested in several environments to verify all works as expected.
Fixes #671