-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install llvm-test-suite from copr #732
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,8 @@ prepare: | |
# potential dependency solving issues when rpms depending on llvm-libs are | ||
# already in the system. | ||
- dnf -y install --best llvm-libs | ||
# Use a newer llvm-test-suite version from copr. | ||
- dnf copr enable -y @fedora-llvm-team/llvm-test-suite $COPR_CHROOT | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jchecahi I think we have another reason for lowering the testing-farm repo instead of raising our own: We now have two repos to add ;) @nikic This looks good to me. But I wonder what will happen if we for example add a new chroot to the snapshot builds, we would need to add it here as well, right? For example, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, we'd have to add the new chroots here, similar to how we do in llvm-compat-packages. Though we don't need to do anything for new fedora versions, as those get forked automatically. I can go ahead and add the cs10 chroots now. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The cs10 chroots are now present: https://copr.fedorainfracloud.org/coprs/g/fedora-llvm-team/llvm-test-suite/monitor/ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
@nikic awesome. Thank you! |
||
|
||
- name: "Check that snapshot (~pre) version of LLVM is installed" | ||
how: shell | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes sense to me. Just a little comment: could you remove the blank line above this one so we have the whole section packed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!