Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinue removing bundled egg-info. #232

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gordonmessmer
Copy link
Member

No description provided.

@hroncok
Copy link
Member

hroncok commented Apr 20, 2020

Is has_bundled_egg_info unused now?

The proper fixer might be to only do this if there are binaries inside. However that might be tedious.

I strongly suggest to put the rationale into the commit message. The lack of rationale for adding this in the first place is now hurting. 8 years from now, somebody might wonder why was this removed and we could be long gone.

@gordonmessmer
Copy link
Member Author

Is has_bundled_egg_info unused now?

Seems to be. I waffled on removing it, but I suppose there wouldn't be a reason not to... We can always pull it back from history.

The proper fixer might be to only do this if there are binaries inside. However that might be tedious.

I can look into that. Do you happen to know an example of a package that's published with binaries inside?

I strongly suggest to put the rationale into the commit message.

Definitely.

@hroncok
Copy link
Member

hroncok commented Apr 23, 2020

Do you happen to know an example of a package that's published with binaries inside?

I don't, really. Let's say we don't do this until proven otherwise?

@gordonmessmer
Copy link
Member Author

Reference, in case anyone reviews this in the future:

https://bugzilla.redhat.com/show_bug.cgi?id=1825455#c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants