Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add policy for nbdkit #1870

Draft
wants to merge 1 commit into
base: rawhide
Choose a base branch
from
Draft

Add policy for nbdkit #1870

wants to merge 1 commit into from

Conversation

5umm3r15
Copy link
Contributor

Add interfaces to virt and fix policy for nbdkit

Resolves: rhbz#2182505

@5umm3r15 5umm3r15 force-pushed the add-nbdkit branch 2 times, most recently from 1b55f9f to 9aefe1e Compare October 10, 2023 10:29
zpytela
zpytela reviewed Oct 19, 2023
View reviewed changes
policy/modules/contrib/nbdkit.fc Outdated Show resolved Hide resolved
policy/modules/contrib/nbdkit.te Outdated Show resolved Hide resolved
policy/modules/contrib/nbdkit.te Outdated Show resolved Hide resolved
policy/modules/contrib/nbdkit.fc Show resolved Hide resolved
@packit-as-a-service
Copy link

Cockpit tests failed for commit 5e88d9e. @martinpitt, @jelly, @mvollmer please check.

@martinpitt
Copy link
Contributor

Ugh, cockpit f39/rawhide tests are a trainwreck:

  • rawhide installs an (old) cockpit-system-303-2.fc40.noarch from Fedora, instead of the cockpit main builds COPR. This is once again that TF tag-repository priority inflation that breaks the show. We need a hack similar to cockpit-project/cockpit-podman@5ab52df in cockpit to fix that. I'll send a PR.
  • F39 has the correct cockpit-system RPM from the COPR, but I have a feeling it's the wrong cockpit-storaged. That installation is unfortunately not shown in the logs.

So either something changed recently in Testing Farm again, or this has always been lurking and some combination of Fedora composes and COPR breaks this. I'll send some debugging improvement and a workaround for that broken TF behaviour, then we can retry these.

Sorry for the mess!

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Oct 30, 2023
@martinpitt
fmf: Show all cockpit package versions
0546069 
This will help us to investigate issues like in [1] where Testing Farm's
greedy tag repo stomps over our COPR config.

fedora-selinux/selinux-policy#1870 (comment)
@martinpitt martinpitt mentioned this pull request Oct 30, 2023
Merged
@martinpitt
Copy link
Contributor

martinpitt commented Oct 30, 2023 •
edited
Loading

@thrix: https://gitlab.com/testing-farm/infrastructure/-/blob/testing-farm/ranch/public/citool-config/guest-setup/pre-artifact-installation/templates/tag.repo.j2?ref_type=heads claims that it would exclude cockpit packages, but (1) apparently it doesn't, and (2) this is also wrong: we do want the tag repository, it should just not trump COPRs -- we need "highest version wins", not "tag repo is special" (and I believe that is true for most packages). Can you please drop the exclude=?

@martinpitt martinpitt mentioned this pull request Oct 31, 2023
Merged
martinpitt added a commit to cockpit-project/cockpit that referenced this pull request Oct 31, 2023
@martinpitt
fmf: Show all cockpit package versions
bcc2811 
This will help us to investigate issues like in [1] where Testing Farm's
greedy tag repo stomps over our COPR config.

fedora-selinux/selinux-policy#1870 (comment)
@martinpitt
Copy link
Contributor

cockpit-project/cockpit#19547 landed, so please either retry them or force-push this PR, or ignore the two failures.

@thrix
Copy link

thrix commented Oct 31, 2023

@martinpitt messaged you on Slack, I would like to look at it, but seems I am missing what is wrong

@5umm3r15
Add policy for nbdkit
d42e623 
Add interfaces to virt and fix policy for nbdkit

Resolves: rhbz#2182505
@zpytela
Copy link
Contributor

zpytela commented Oct 31, 2023

LGTM, thank you.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit d42e623. @martinpitt, @jelly, @mvollmer please check.

@martinpitt
Copy link
Contributor

I talked to Miro, we have a plan for TF to fix this globally, and I just landed the workaround in cockpit. So please click re-run on the failed rawhide test or do a comment with /packit retest-failed. Thanks and sorry for the noise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zpytela zpytela zpytela left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@5umm3r15 @martinpitt @thrix @zpytela