Draft: Policies required for logind BPF-based hidraw revoke #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usb devices is a broad stroke, our plan is for logind to access /dev/hidraw devices but those are under the more rather generic usb_devices_t label.
Our plan is to add support for /dev/hidraw devices to logind via its TakeDevice() - this requires that logind passes the fd via dbus to the target (usually the compositor).
The current plan is to implement hidraw revoke support via BPF - for this to work logind has to be able to load and run BPF programs.
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the required policies (I think) for systemd-logind to access
/dev/hidrawdevices, pass the fd via DBus to the requestor (usually a compositor).On vt-switch we expect logind to revoke the devices via an eBPF program (wip kernel patches) so we need the ability to load and run those. The corresponding PR for systemd is systemd/systemd#29797.
Filing as Draft, this is all still WIP. Feel free to close, I just wanted a linkable PR to work on this :)