Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confine gnome-remote-desktop #2269

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

bachradsusi
Copy link
Member

  • add new gnome_remote_desktop_t port mapping for tcp 3389-3399
  • add file type for /var/lib/gnome-remote-desktop(/.*)?
  • add new domain and transition for /usr/libexec/gnome-remote-desktop-daemon

@bachradsusi bachradsusi changed the title WIP: Confine gnome-remote-desktop Confine gnome-remote-desktop Aug 27, 2024
Copy link
Contributor

@zpytela zpytela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the suggested changes or reply back.

policy/modules/contrib/gnome_remote_desktop.if Outdated Show resolved Hide resolved
policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
@bachradsusi
Copy link
Member Author

@zpytela PTAL

I'll merge all the commits into one when you say it's ready to be merged.

Copy link
Contributor

@zpytela zpytela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with squashing.

policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
policy/users Outdated Show resolved Hide resolved
@bachradsusi
Copy link
Member Author

@zpytela PTAL

Please be more specific with other requirements. I'm kind of beginner in this and I need specific instructions.

policy/modules/contrib/dbus.te Outdated Show resolved Hide resolved
policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
policy/modules/contrib/gnome_remote_desktop.te Outdated Show resolved Hide resolved
policy/modules/services/xserver.te Outdated Show resolved Hide resolved
@bachradsusi
Copy link
Member Author

@zpytela another round, PTAL

- add new gnome_remote_desktop_t port mapping for tcp 3389-3399
- add file type for /var/lib/gnome-remote-desktop(/.*)?
- add new domain and transition for /usr/libexec/gnome-remote-desktop-daemon

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2271661
@zpytela
Copy link
Contributor

zpytela commented Sep 11, 2024

Merging, thank you.

@zpytela zpytela merged commit ce83836 into fedora-selinux:rawhide Sep 11, 2024
6 checks passed
@XhmikosR
Copy link
Contributor

Thanks @bachradsusi and @zpytela for your work!

Do you plan to backport this patch to Fedora 40? I'm asking because it's supposed to fix https://bugzilla.redhat.com/show_bug.cgi?id=2271661 and it's a pity that without this patch GRD doesn't work OOTB on Fedora stable.

@zpytela
Copy link
Contributor

zpytela commented Sep 11, 2024

F40 backport is considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants