Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SELinux policy for sandbox X server to fix 'sandbox -X' command #2327

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

krishjainx
Copy link
Contributor

Hi,

Hope you're well! I was speaking with @rhatdan and trying to make "sandbox -X" work properly. This issue occurs on Rawhide. The error I get is:

/usr/share/sandbox/sandboxX.sh: line 16: 810257 Aborted                 (core dumped) /usr/bin/Xwayland -terminate -dpi $DPI -retro -geometry $SCREENSIZE -decorate -displayfd 5 5>&1 2> /dev/null

I ran it with setenforce 0 and it worked then. The AVC I saw immediately in the problematic run was:

type=AVC msg=audit(1721850176.924:703): avc: denied { search } for pid=30127 comm="Xwayland" name="dev" dev="proc" ino=24178 scontext=unconfined_u:unconfined_r:sandbox_xserver_t:s0:c149,c693 tcontext=system_u:object_r:sysctl_dev_t:s0 tclass=dir permissive=0

Dan says there's no problem allowing that, and that he's sure there are plenty more.

I've spoken with Dan, Lukas, Zdeněk, and Petr, and Dan suggested this implementation.

Not tested yet.

@zpytela
Copy link
Contributor

zpytela commented Sep 4, 2024

@krishjainx The content LGTM now. Would you just mind squashing the commits into 1 and add a commit message explaining (one or two sentences) what or why you are doing?

@krishjainx
Copy link
Contributor Author

Done

@krishjainx krishjainx marked this pull request as ready for review September 4, 2024 16:36
Copy link
Contributor

@zpytela zpytela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zpytela
Copy link
Contributor

zpytela commented Sep 6, 2024

Merging, thank you.

@zpytela zpytela merged commit d62b0d3 into fedora-selinux:rawhide Sep 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants