Add support for Alpine on LGBM #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit bumps lightgbm to v0.9.14 and makes it possible to use LGBM on nodes with AMD64 architecture using Alpine.
artpdr
requested changes
Feb 28, 2024
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
============================================
+ Coverage 80.37% 80.52% +0.15%
- Complexity 469 479 +10
============================================
Files 48 50 +2
Lines 1620 1648 +28
Branches 157 158 +1
============================================
+ Hits 1302 1327 +25
- Misses 231 233 +2
- Partials 87 88 +1 ☔ View full report in Codecov by Sentry. |
added 3 commits
February 29, 2024 13:18
This commit changes the paths when loading the dependencies on amd64 architecture in order to reflect the changes made on the jar.
This commit changes the path when loading the dependencies on amd64 architecture in order to reflet the change on the jar structure from amd64/alpine to amd64/musl.
gandola
reviewed
Mar 12, 2024
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
gandola
reviewed
Mar 12, 2024
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
artpdr
requested changes
Mar 12, 2024
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
added 2 commits
March 13, 2024 14:24
This commit changes the code structure by adding a new enum representing the libc implementation available. In order to detect the libc implementation, an env variable FDZ_OPENML_JAVA_LIBC must be set with either 'glibc' or 'musl', and using glibc if this env variable is not defined. This new enum is also used along side with the cpu architecture enum to represent the infrastructure running the code.
artpdr
requested changes
Mar 13, 2024
...gbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/Infrastructure.java
Outdated
Show resolved
Hide resolved
...gbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/Infrastructure.java
Outdated
Show resolved
Hide resolved
...gbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/Infrastructure.java
Outdated
Show resolved
Hide resolved
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Show resolved
Hide resolved
artpdr
requested changes
Mar 13, 2024
...gbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/Infrastructure.java
Show resolved
Hide resolved
artpdr
requested changes
Mar 13, 2024
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
This commit includes information in the README about the new ENV variable used to load dependencies for musl-based OS.
Co-authored-by: Artur Pedroso <[email protected]>
artpdr
reviewed
Mar 14, 2024
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
artpdr
reviewed
Mar 14, 2024
...tgbm-provider/src/test/java/com/feedzai/openml/provider/lightgbm/TestLibcImplementation.java
Outdated
Show resolved
Hide resolved
added 2 commits
March 14, 2024 13:42
This commits changes the if statment on the method Infrastructure#getLgbmNativeLibsFolder into a switch statement.
artpdr
reviewed
Mar 14, 2024
...gbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/Infrastructure.java
Outdated
Show resolved
Hide resolved
artpdr
reviewed
Mar 14, 2024
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMUtils.java
Outdated
Show resolved
Hide resolved
artpdr
approved these changes
Mar 14, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit bumps lightgbm to v0.9.14 and makes it possible to use LGBM on nodes with AMD64 architecture using Alpine.