Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Emojis in emoji button #44

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

feat: Emojis in emoji button #44

wants to merge 8 commits into from

Conversation

zzanp
Copy link
Contributor

@zzanp zzanp commented Jan 2, 2020

No description provided.

@zzanp zzanp mentioned this pull request Jan 3, 2020
Copy link
Owner

@feelfreelinux feelfreelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good, just some nitpicking :)

Thanks for your contribution!

@@ -368,6 +368,7 @@ class InputBarWidgetState extends State<InputBarWidget> {
}

Widget _drawButtons() {
List<String> lennies = ['( ͡° ͜ʖ ͡°)','( ͡° ʖ̯ ͡°)','( ͡º ͜ʖ͡º)','( ͡°( ͡° ͜ʖ( ͡° ͜ʖ ͡°)ʖ ͡°) ͡°)','(╥﹏╥)','(╯︵╰,)','(ʘ‿ʘ)','(。◕‿‿◕。)','(⇀‸↼‶)','(òóˇ)','(✌ ゚ ∀ ゚)☞','ʕ•ᴥ•ʔ','ᶘᵒᴥᵒᶅ','(⌒(oo)⌒)','ᄽὁȍ ̪ őὀᄿ','( ͡€ ͜ʖ ͡€)','( ͡° ͜ʖ ͡°)','( ͡° ͜ʖ ͡°)ノ⌐■-■','(⌐ ͡■ ͜ʖ ͡■)','¯\\\\\\_(ツ)\\_/¯','(ꖘ⏏ꖘ)','(╯°□°)╯︵ ┻━┻','( ͡~ ͜ʖ ͡°)','( ಠ_ಠ)','(・へ・)','(ง✿﹏✿)ง','(づ•﹏•)づ','乁(♥ ʖ̯♥)ㄏ','|૦ઁ෴૦ઁ','乁(⫑ᴥ⫒)ㄏ','(ꖘ‸ꖘ)','(✿ ͟ʖ✿)','(งⱺ ͟ل͜ⱺ)ง','( ̄෴ ̄)','ヽ( ͠°෴ °)','└[⚆ᴥ⚆]┘','ヽ(☼ᨓ☼)ノ','XD','(ⴲ﹏ⴲ)','(ಠ‸ಠ)','(ง ͠° ͟ل͜ ͡°)ง','( ಠ_ಠ)','(-‸ლ)','( ͡° ͜ʖ ͡° )つ──☆*:・゚','(╭☞σ ͜ʖσ)╭☞"'];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move it to top file scope

@@ -89,7 +91,7 @@ class _AuthorWidgetState extends State<AuthorWidget> {
showFullDate
? Utils.getDateFormat(
widget.date, 'dd.MM.yyyy \'o\' HH:mm:ss')
: Utils.getSimpleDate(widget.date),
: Utils.getSimpleDate(widget.date) + (widget.app != null ? " via ${widget.app}" : ""),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use templates

@@ -386,7 +387,30 @@ class InputBarWidgetState extends State<InputBarWidget> {
child: _drawIconRound(
icon: Icons.mood,
tooltip: "Emotikony",
onTap: () => {}, // TODO: dodac ekran z lennymi
onTap: () => {
showDialog(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export it to function (ex. _showLennyPicker)

@@ -187,7 +187,7 @@ class _LinkCommentWidgetState extends State<LinkCommentWidget> {
text: showFullDate
? Utils.getDateFormat(
model.date, 'dd.MM.yyyy \'o\' HH:mm:ss')
: Utils.getSimpleDate(model.date),
: Utils.getSimpleDate(model.date) + (model.app != null ? " via ${model.app}" : ""),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use template instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants