feat: #3555

[jtdLab]

Make emit of BlocBase return an Emitter which is used as an "internal" Emitter in Bloc replacing the old emit function. Inside Cubit the Emitter is used instead of the old emit function allowing easy handling of subscriptions as described in #3555.

Status

READY

Breaking Changes

These changes might be breaking for clients which override emit (happened in replay_bloc).
Else usage should be the same.

Type of Change

• ✨ New feature (non-breaking change which adds functionality)
• 🛠️ Bug fix (non-breaking change which fixes an issue)
• ❌ Breaking change (fix or feature that would cause existing functionality to change)
• 🧹 Code refactor
• ✅ Build configuration change
• 📝 Documentation
• 🗑️ Chore

[codecov]

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.87%. Comparing base (d1abf0f) to head (b36f0ee).
Report is 16 commits behind head on master.

Files with missing lines	Patch %	Lines
packages/bloc/lib/src/emitter.dart	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##            master    #3933      +/-   ##
===========================================
- Coverage   100.00%   99.87%   -0.13%     
===========================================
  Files           31       31              
  Lines          803      807       +4     
===========================================
+ Hits           803      806       +3     
- Misses           0        1       +1     

Flag	Coverage Δ
bloc	99.44% <90.90%> (-0.56%)	⬇️
replay_bloc	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[felangel]

Unfortunately this is not sufficient because there are APIs and implementation details of the current Emitter implementation that are bloc and event handler specific. Making this work will likely involve splitting Emitter into a base Emitter and a BlocEmitter. I'm looking into this now and will hopefully have something ready to ship in the coming weeks 👍

[felangel]

Closing this for now based on my comment but happy to continue the discussion 👍
Thanks so much for taking the time to contribution -- I really appreciate it! I'll try to get this sorted out very soon!