Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(flutter_firebase_login): use emit.onEach in AppBloc #4223

Merged
merged 5 commits into from
Aug 27, 2024
Merged

refactor(flutter_firebase_login): use emit.onEach in AppBloc #4223

merged 5 commits into from
Aug 27, 2024

Conversation

LukasMirbt
Copy link
Contributor

@LukasMirbt LukasMirbt commented Aug 3, 2024 •
edited
Loading

Status

READY

Breaking Changes

NO

Description

Makes changes similar to flutter_login:

  • Uses emit.onEach instead of handling user stream subscription manually.
  • Renames AppLogoutRequested to AppLogoutPressed.
  • Breaks out duplicated user to status transformation to a factory constructor.
  • Breaks out duplicated blocTest build methods to a shared buildBloc method.
  • Uses types instead of strings in app_bloc_test.dart.
  • Updates tutorial to reflect the changes made in this PR.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@LukasMirbt LukasMirbt requested a review from felangel as a code owner August 3, 2024 20:09
@felangel felangel added example Example application refactor Refactor an existing implementation labels Aug 21, 2024
felangel
felangel approved these changes Aug 27, 2024
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution! 💙

@felangel felangel merged commit 0c68c96 into felangel:master Aug 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@LukasMirbt LukasMirbt

Labels
example Example application refactor Refactor an existing implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasMirbt @felangel