feat(mocktail): improve verifyNoMoreInteractions failure message (#118)

felangel · Mar 1, 2022 · 447575a · 447575a
1 parent 70e915f
commit 447575a
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 7 deletions.
diff --git a/packages/mocktail/lib/src/_real_call.dart b/packages/mocktail/lib/src/_real_call.dart
@@ -21,7 +21,7 @@ class RealCall {
 
   @override
   String toString() {
-    var verifiedText = verified ? '[VERIFIED] ' : '';
+    final verifiedText = verified ? '[VERIFIED] ' : '';
     return '$verifiedText$mock.${invocation.toPrettyString()}';
   }
 }

diff --git a/packages/mocktail/lib/src/mocktail.dart b/packages/mocktail/lib/src/mocktail.dart
@@ -443,7 +443,9 @@ void verifyNoMoreInteractions(dynamic mock) {
   if (mock is Mock) {
     final unverified = mock._realCalls.where((inv) => !inv.verified).toList();
     if (unverified.isNotEmpty) {
-      fail('No more calls expected, but following found: ${unverified.join()}');
+      fail(
+        '''No more calls expected, but following found: ${unverified.join(', ')}\nDid you forget to call verify?\nExample: verify(() => cat.meow()).called(1);''',
+      );
     }
   } else {
     _throwMockArgumentError('verifyNoMoreInteractions', mock);

diff --git a/packages/mocktail/test/mockito_compat/verify_test.dart b/packages/mocktail/test/mockito_compat/verify_test.dart
@@ -489,13 +489,22 @@ void main() {
       verifyNoMoreInteractions(mock);
     });
 
-    test('any unverified touch fails', () {
+    test('any unverified touch fails (single invocation)', () {
       mock.methodWithoutArgs();
       expectFail(
-          'No more calls expected, but following found: '
-          '_MockedClass.methodWithoutArgs()', () {
-        verifyNoMoreInteractions(mock);
-      });
+        '''No more calls expected, but following found: _MockedClass.methodWithoutArgs()\nDid you forget to call verify?\nExample: verify(() => cat.meow()).called(1);''',
+        () => verifyNoMoreInteractions(mock),
+      );
+    });
+
+    test('any unverified touch fails (multiple invocations)', () {
+      mock
+        ..methodWithoutArgs()
+        ..methodWithOptionalArg();
+      expectFail(
+        '''No more calls expected, but following found: _MockedClass.methodWithoutArgs(), _MockedClass.methodWithOptionalArg(null)\nDid you forget to call verify?\nExample: verify(() => cat.meow()).called(1);''',
+        () => verifyNoMoreInteractions(mock),
+      );
     });
 
     test('verified touch passes', () {