Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add sample_params method to effects and proper Lift test likelihood #149

Merged
merged 3 commits into from
Dec 15, 2024

Conversation

felipeangelimvieira
Copy link
Owner

Closes #148, #143

@felipeangelimvieira felipeangelimvieira added the enhancement New feature or request label Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 96.21212% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.15%. Comparing base (552dcfb) to head (c5752c3).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/prophetverse/effects/base.py 90.90% 2 Missing ⚠️
src/prophetverse/sktime/base.py 66.66% 2 Missing ⚠️
src/prophetverse/effects/lift_likelihood.py 98.03% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   96.28%   96.15%   -0.14%     
==========================================
  Files          39       40       +1     
  Lines        1535     1612      +77     
==========================================
+ Hits         1478     1550      +72     
- Misses         57       62       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felipeangelimvieira felipeangelimvieira merged commit a4aa653 into main Dec 15, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Add sample_params method to Effect interface
1 participant