Fix erroneous json encoding

felixhammerl · Oct 20, 2023 · 5d40914 · 5d40914
1 parent 230174c
commit 5d40914
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/steps/transform/src/handler/transform.py b/steps/transform/src/handler/transform.py
@@ -24,7 +24,7 @@ def transform_report(event, context):
     result = s3.put_object(
         Bucket=website_bucket,
         Key="index.html",
-        Body=json.dumps(page).encode(),
+        Body=page.encode(),
     )
 
 

diff --git a/steps/transform/test/unit/handler/test_transform.py b/steps/transform/test/unit/handler/test_transform.py
@@ -39,8 +39,7 @@ def test_should_transform_report_to_html():
     transform_report(context=None, event=None)
 
     result = s3.get_object(Bucket=WEBSITE_BUCKET, Key=f"index.html")
-    text = result["Body"].read().decode()
-    html_from_s3 = json.loads(text)
+    html_from_s3 = result["Body"].read().decode()
 
     html_from_fixture = read_fixture(filename="index.html")