Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing new : updates dependencies #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryuran
Copy link

@ryuran ryuran commented Jul 9, 2018

Update dependencies and reorganize code.

@felixzapata
Copy link
Owner

When I run some of the gulp tasks (for example gulp test or gulp release:minor) I obtain this error:

  gulpInst.start.apply(gulpInst, toRun);
                   ^

TypeError: Cannot read property 'apply' of undefined

My global version of Gulp is 3.9.1 and the local installed with the updates is 4.0.0. My node version is v9.5.0.

Do I need to update my global version of Gulp?

@felixzapata felixzapata self-assigned this Jul 9, 2018
@ryuran
Copy link
Author

ryuran commented Jul 10, 2018

@felixzapata with gulp@4 you should not have a global gulp installed.
If you need the same behavior, install gulp-cli to your global.
gulp-cli resolve you local gulp (3.9 or 4) it should work with your other projects even if it's gulp3.9

@felixzapata
Copy link
Owner

felixzapata commented Jul 11, 2018

Inside the release task, the gulp.series with a callback at the end does not work ok

captura de pantalla 2018-07-11 a las 21 29 03

@felixzapata
Copy link
Owner

It is looks like more related with the code inside of the done function. The undefined is due to the chalk.red('error.message').

@felixzapata
Copy link
Owner

The task can finish ok if the function changes like this:

function done(done) {
  log(chalk.green('Release finished successfully'));
  done();
}

But I would like to keep the system to show if any error occur in a previous task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants