Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(style): rounded service view #1947

Closed
wants to merge 2 commits into from

Conversation

DenysMb
Copy link
Contributor

@DenysMb DenysMb commented Oct 26, 2024

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Added a 4px padding in the service view and added a 4px border-radius

Motivation and Context

Some new applications (like Arc Browser) are using small padding and a little border radius to the main view to give us this new modern look, so I thought it would be nice to do the same for Ferdium.

Screenshots

Screenshot_20241026_192343
Screenshot_20241026_192409
Screenshot_20241026_192547
Screenshot_20241026_192205
Screenshot_20241026_192303

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

Added a 4px padding in the service view and added a 4px border-radius.

@DenysMb DenysMb mentioned this pull request Oct 26, 2024
6 tasks
@vraravam
Copy link
Contributor

Can this be merged with the other PR that you have created?

@DenysMb
Copy link
Contributor Author

DenysMb commented Oct 27, 2024

Can this be merged with the other PR that you have created?

The other PR already includes the change that we have in this one.

Sorry, I should have been clear about that.

@vraravam
Copy link
Contributor

Closing in favor of #1948

@vraravam vraravam closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants