Update GroupMe DOM filtering to use latest web app conventions #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes look good to me, but please update the version inside package.json as described in #468 |
@cloopadoop friendly reminder so we can merge this. |
SpecialAro
approved these changes
Jan 7, 2024
SpecialAro
force-pushed
the
groupme-patch
branch
from
5c4c718 to
381dfa9
Compare
|
@allcontributors - please add @cloopadoop for code |
|
I've put up a pull request to add @cloopadoop! 🎉 |
apologies for not acting on this--didn't get notified for some reason, even though I'm subscribed! Thanks for taking care of it @SpecialAro! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
The previous code for this recipe implies that the GroupMe web app used to use Angular(JS), given that it was filtering based on an .ng-hide class. In use, the plugin was simply returning all conversation threads, rather than filtering for unread and unmuted conversations. So if there were 7 total, read conversations, the notification badge showed 7.
This update queries for conversations that have the much more direct .unread class and also do not contain the muted class inside them. This has made the notification badge count accurate for me.