update template PR #469
update template PR #469
Conversation
| @@ -7,8 +7,9 @@ | |||
|
|
|||
| Please ensure you've completed all of the following. | |||
|
|
|||
| - [ ] I have read the [Contributing Guidelines](https://github.com/ferdium/ferdium-recipes/blob/HEAD/CONTRIBUTING.md) for this project. | |||
| - [ ] I agree to follow the [Code of Conduct](https://github.com/ferdium/ferdium-recipes/blob/HEAD/CODE_OF_CONDUCT.md) that this project adheres to. | |||
| - [ ] I have read the [Contributing Guidelines](https://github.com/ferdium/ferdium-app/blob/develop/CONTRIBUTING.md) for this project. | |||
There was a problem hiding this comment.
Please undo the 1st two lines of changes. Though the issues get reported in the main (ferdium-app) repo, the contriuting guidelines and scripts to run are different between the 2 repos.
There was a problem hiding this comment.
I understand what you mean but the url on the 1st line does not work. I used the CONTRIBUTING.md doc to install repo recipes on my local.
Should we create a new CONTRIBUTING.md ?
There was a problem hiding this comment.
@Mralexandresys is right, the link to https://github.com/ferdium/ferdium-recipes/blob/HEAD/CONTRIBUTING.md is broken.
Maybe I fired too quicky in merging #471, @vraravam let us know if something has to be updated.
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| - [ ] I agree to follow the [Code of Conduct](https://github.com/ferdium/ferdium-recipes/blob/HEAD/CODE_OF_CONDUCT.md) that this project adheres to. | ||
| - [ ] I have read the [Contributing Guidelines](https://github.com/ferdium/ferdium-app/blob/develop/CONTRIBUTING.md) for this project. | ||
| - [ ] I agree to follow the [Code of Conduct](https://github.com/ferdium/ferdium-app/blob/develop/CODE_OF_CONDUCT.md) that this project adheres to. | ||
| - [ ] I update the version package [Updating](https://github.com/ferdium/ferdium-recipes/blob/main/docs/updating.md#4-updating-the-version-number) |
There was a problem hiding this comment.
Ah this is cool, then more ppl will hopefully do the version update right away without having to get reminded.
There was a problem hiding this comment.
Yes! I would've appreciated knowing about this prior to the commit hook yelling at me about it
SpecialAro
force-pushed
the
update-template-pr
branch
from
44f62b8 to
2a77f42
Compare
|
@allcontributors - please add @Mralexandresys for infra |
|
I've put up a pull request to add @Mralexandresys! 🎉 |
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
change url in template request
Add row check list for update package version