Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cache for lint scripts #482

Closed
wants to merge 1 commit into from
Closed

Use cache for lint scripts #482

wants to merge 1 commit into from

Conversation

rdwz
Copy link
Contributor

@rdwz rdwz commented Dec 19, 2023

Description of Change

$ eslint --help
...
Caching:
--cache Only check changed files - default: false
...

$ prettier --help
...
--cache Only format changed files. Cannot use with --stdin-filepath.
Defaults to false.

.gitignore Show resolved Hide resolved
Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont agree with the caching. We (as maintainers) have seen innumerable times where a merged code was also not linted/formatted properly. So, only processing the changed files will not take that into account. Also, the time taken for processing all files (as opposed to only the changed files) is quite bearable for now.

@vraravam
Copy link
Contributor

vraravam commented Jun 1, 2024

Closing

@vraravam vraravam closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants