Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create sqlite DB file if DB_CONNECTION undefined or eq sqlite #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tigattack
Copy link

This eliminates some pointless processing and a confusing log message in the output.

@SpecialAro
Copy link
Member

Hello @tigattack, thank you for making this PR.

Have you tried to run ferdium-server without an SQLite file? By using a MYSQL server for instance?

If so, did it work? When I made the re-write of the code from the Adonis dependency upgrade I don't quite remember if I left that feature working.

@tigattack
Copy link
Author

Yep, MySQL seems to be working fine for me. I was using it on 1.3.16 for a long time and moved to 2.0.6 earlier, where I encountered a few errors, but my guess is they are a result of some slightly funky logic rather than being specifically MySQL related. You'd know better than I, though - See #122.

@SpecialAro
Copy link
Member

In fact, before updating the adonisjs dependency I did account for SQLITE databases, but forgot about other databases.

Instead of removing the logic of migrations in your PR I would suggest to adapt the script to fit MYSQL when the DB_CONNECTION != sqlite (for instance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants