Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dart webassembly-language-support.md #1380

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Conversation

KyleFin
Copy link
Contributor

@KyleFin KyleFin commented Sep 14, 2024

Update language matrix to be aligned with @kevmoo's 6cb4c1e

Content must go through a pre-merge checklist.

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

  • The title, template, and date are all set
  • Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
  • File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep $'\r' | wc -l and expect 0 as a result)
  • Has passed bart check
  • Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
  • Headings are using Title Case
  • Code blocks have the programming language set to properly highlight syntax and the proper copy directive
  • Have tested with npm run test and resolved all errors
  • Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

@@ -39,7 +39,7 @@ Some languages, like CSS, PowerShell, and "Shell", don't really have a meaningfu
| [Kotlin (JVM)][Kotlin] | ✅ | ✅ | ✅ | ⏳ |
| [Kotlin (Wasm)][Kotlin] | ⏳ | ✅ | ✅ | ❌ |
| [Rust][Rust] | ✅ | ✅ | ✅ | ✅ |
| [Dart][Dart] | | | | ❌ |
| [Dart][Dart] | | | | ❌ |

* _Core_ means there is an implementation of WebAssembly 1.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about this definition. GC languages require 2.0, right? So should Core column be ❌ for Dart, Java, Kotlin, etc?

If not, then I believe Dart should be ✅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@technosophos I'm going to merge this on the basis of Kotlin being green, but I may be misunderstanding your intent with the Core column. If so let me know and we can put it back to what you intended (running it past Kyle of course).

@itowlson
Copy link
Contributor

CI fail is an unrelated broken link at sigstore

@itowlson itowlson merged commit 4d1816b into fermyon:main Sep 15, 2024
2 of 3 checks passed
@itowlson
Copy link
Contributor

My apologies, @KyleFin, I forgot to say thank you for this!

@KyleFin
Copy link
Contributor Author

KyleFin commented Sep 16, 2024

Happy to help! Thanks @itowlson :)

@KyleFin KyleFin deleted the patch-2 branch September 16, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants