Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(wasm-languages): rust updates #1404

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

vdice
Copy link
Member

@vdice vdice commented Oct 30, 2024

Mostly focused on updating the example app code/spin.toml, similar to #1403

@vdice vdice requested a review from itowlson October 30, 2024 21:37
@vdice
Copy link
Member Author

vdice commented Oct 30, 2024

I'm tempted to completely remove the following WAGI-related mentions:

Rust can use Spin's native executor as well as Spin's Wagi executor. We strongly recommend the native one, as it has more features.
,
### Writing Wagi-Based Rust Apps
It is also possible to write a Wagi application in Rust and run it in Spin or Wagi. Examples of this exist [in the Wagi examples repository](https://github.com/deislabs/wagi-examples).
and
- DeisLabs has some [Rust Wagi examples](https://github.com/deislabs/wagi-examples)

Thoughts?

Copy link

🚀 preview deployed successfully to Fermyon Cloud and available at https://fermyon-developer-pr-1404-rzwxjwvh.fermyon.app

Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes this was ancient. Thanks

@itowlson
Copy link
Contributor

I'm okay with removing the WAGI mentions. Do you want me to hold off on merging this PR, or do you envisage deferring those to a separate PR?

@vdice
Copy link
Member Author

vdice commented Oct 30, 2024

I'm okay with removing the WAGI mentions. Do you want me to hold off on merging this PR, or do you envisage deferring those to a separate PR?

👍 I'll push the changes in this PR.

@vdice
Copy link
Member Author

vdice commented Oct 30, 2024

@itowlson most wagi mentions removed in ef8aec6

@itowlson itowlson merged commit c7fefca into main Oct 30, 2024
2 of 3 checks passed
@vdice vdice deleted the docs/wasm-lang-rust-updates branch October 31, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants