Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OpenApi Parser v2 auth header papercuts #2162

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

RohinBhargava
Copy link
Member

Short description of the changes made

  • Previously, we did not include a default auth scheme if the security section was not filled out in the v2 parser, now we select the first in securitySchemes if nothing is specified
  • Previously, we did not fall back to bearerAuth if OAuth2 client credentials aren't specified. Now we do in the v2 parser

What was the motivation & context behind this PR?

  • Go live papercuts

How has this PR been tested?

  • Snapshots and manual cli testing.

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Feb 12, 2025 8:52pm

@RohinBhargava RohinBhargava had a problem deploying to Preview - app.buildwithfern.com February 12, 2025 20:52 — with GitHub Actions Error
@RohinBhargava RohinBhargava had a problem deploying to Preview - app-dev.buildwithfern.com February 12, 2025 20:52 — with GitHub Actions Error
Copy link

github-actions bot commented Feb 12, 2025

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Feb 12, 2025

PR Preview

Copy link

github-actions bot commented Feb 12, 2025

Playwright test results

passed  98 passed
flaky  1 flaky
skipped  2 skipped

Details

stats  101 tests across 9 suites
duration  1 minute, 9 seconds
commit  f69c79b

Flaky tests

chromium › skew-protection/index.test.ts › should contain ?dpl= or x-deployment-id header on all scripts and prefetch requests

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

@RohinBhargava RohinBhargava merged commit 6a1445d into main Feb 13, 2025
16 checks passed
@RohinBhargava RohinBhargava deleted the rohin/oaiv2-auth-headers branch February 13, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants