feat(csharp-sdk): Fix unnecessary Equals and GetHashCode, Add Stringify

generators/csharp/codegen/src/AsIs.ts

@@ -21,10 +21,11 @@ export enum AsIsFiles {
     RawClient = "RawClient.Template.cs",
     RawClientTests = "RawClientTests.Template.cs",
     RawGrpcClient = "RawGrpcClient.Template.cs",
-    StringEnum = "StringEnum.Template.cs",
-    EnumSerializer = "EnumSerializer.cs",
+    EnumSerializer = "EnumSerializer.Template.cs",
     EnumSerializerTests = "EnumSerializerTests.Template.cs",
-    StringEnumSerializer = "StringEnumSerializer.cs",
+    StringEnum = "StringEnum.Template.cs",
+    StringEnumExtensions = "StringEnumExtensions.Template.cs",
+    StringEnumSerializer = "StringEnumSerializer.Template.cs",
     StringEnumSerializerTests = "StringEnumSerializerTests.Template.cs",
     TemplateCsProj = "Template.csproj",
     TemplateTestCsProj = "Template.Test.csproj",

generators/csharp/codegen/src/asIs/StringEnumExtensions.Template.cs

@@ -0,0 +1,6 @@
+namespace <%= namespace%>;
+
+internal static class StringEnumExtensions
+{
+    public static string Stringify(this IStringEnum stringEnum) => stringEnum.Value;
+}

generators/csharp/codegen/src/asIs/StringEnumSerializerTests.Template.cs

@@ -78,7 +78,7 @@ public class DummyObject
 }
 
 [JsonConverter(typeof(StringEnumSerializer<DummyEnum>))]
-public readonly struct DummyEnum : IStringEnum, IEquatable<DummyEnum>
+public readonly record struct DummyEnum : IStringEnum
 {
     public DummyEnum(string value)
     {
@@ -120,36 +120,16 @@ public override string ToString()
         return Value;
     }
 
-    public bool Equals(DummyEnum other)
-    {
-        return Value == other.Value;
-    }
-
     public bool Equals(string? other)
     {
         return Value.Equals(other);
     }
 
-    public override bool Equals(object? obj)
-    {
-        if (obj is null)
-            return false;
-        if (obj is string stringObj)
-            return Value.Equals(stringObj);
-        if (obj.GetType() != GetType())
-            return false;
-        return Equals((DummyEnum)obj);
-    }
-
     public override int GetHashCode()
     {
         return Value.GetHashCode();
     }
 
-    public static bool operator ==(DummyEnum value1, DummyEnum value2) => value1.Equals(value2);
-
-    public static bool operator !=(DummyEnum value1, DummyEnum value2) => !(value1 == value2);
-
     public static bool operator ==(DummyEnum value1, string value2) => value1.Value.Equals(value2);
 
     public static bool operator !=(DummyEnum value1, string value2) => !value1.Value.Equals(value2);

generators/csharp/model/src/ModelGeneratorContext.ts

@@ -36,6 +36,7 @@ export class ModelGeneratorContext extends AbstractCsharpGeneratorContext<ModelC
         ];
         if (this.customConfig["enable-forward-compatible-enums"] ?? false) {
             files.push(AsIsFiles.StringEnum);
+            files.push(AsIsFiles.StringEnumExtensions);
             files.push(AsIsFiles.StringEnumSerializer);
         } else {
             files.push(AsIsFiles.EnumSerializer);

generators/csharp/model/src/enum/StringEnumGenerator.ts

@@ -152,24 +152,7 @@ export class StringEnumGenerator extends FileGenerator<CSharpFile, ModelCustomCo
                 summary: "Returns the string value of the enum.",
                 type: csharp.MethodType.INSTANCE,
                 body: csharp.codeblock((writer) => {
-                    writer.write("return Value;");
-                })
-            })
-        );
-
-        stringEnum.addMethod(
-            csharp.method({
-                access: "public",
-                name: "Equals",
-                parameters: [
-                    csharp.parameter({
-                        name: "other",
-                        type: csharp.Type.reference(this.classReference)
-                    })
-                ],
-                return_: csharp.Type.boolean(),
-                body: csharp.codeblock((writer) => {
-                    writer.write("return Value == other.Value;");
+                    writer.writeTextStatement("return Value");
                 })
             })
         );
@@ -186,20 +169,7 @@ export class StringEnumGenerator extends FileGenerator<CSharpFile, ModelCustomCo
                 ],
                 return_: csharp.Type.boolean(),
                 body: csharp.codeblock((writer) => {
-                    writer.write("return Value.Equals(other);");
-                })
-            })
-        );
-
-        stringEnum.addMethod(
-            csharp.method({
-                access: "public",
-                name: "GetHashCode",
-                override: true,
-                return_: csharp.Type.integer(),
-                parameters: [],
-                body: csharp.codeblock((writer) => {
-                    writer.write("return Value.GetHashCode();");
+                    writer.writeTextStatement("return Value.Equals(other)");
                 })
             })
         );

generators/csharp/sdk/src/SdkGeneratorContext.ts

@@ -134,6 +134,7 @@ export class SdkGeneratorContext extends AbstractCsharpGeneratorContext<SdkCusto
         }
         if (this.customConfig["enable-forward-compatible-enums"] ?? false) {
             files.push(AsIsFiles.StringEnum);
+            files.push(AsIsFiles.StringEnumExtensions);
             files.push(AsIsFiles.StringEnumSerializer);
         } else {
             files.push(AsIsFiles.EnumSerializer);