Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ir): Add CLI version and definition URL #4516

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amckinney
Copy link
Contributor

Overview

This adds the cliVersion and definitionUrl property to the IR's SourceConfig type so that the generator has access to additional source information during generation. Note that this means the SourceConfig now contains the following information:

  1. The CLI version
  2. The Fern definition files
  3. The source files used to create the Fern definition (i.e. AsyncAPI, OpenAPI, etc files), if any.

All of this information has to do with the "source" of the IR, so it feels natural to include them all alongside one another.

Implementation

This effectively consolidate the fields that are passed to the remote code generation service (link) into the IR so that we can rely on the generator-agent for more functionality.

The IR changes are included as optional parameters in IRv53 for now, but they should later be marked as required in a future IR change (as noted in the CHANGELOG.md).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants