feat(ir): Add CLI version and definition URL #4516
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds the
cliVersion
anddefinitionUrl
property to the IR'sSourceConfig
type so that the generator has access to additional source information during generation. Note that this means theSourceConfig
now contains the following information:All of this information has to do with the "source" of the IR, so it feels natural to include them all alongside one another.
Implementation
This effectively consolidate the fields that are passed to the remote code generation service (link) into the IR so that we can rely on the
generator-agent
for more functionality.The IR changes are included as optional parameters in IRv53 for now, but they should later be marked as required in a future IR change (as noted in the
CHANGELOG.md
).