feat(seed): Always include docker logs #4784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsinghvi
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a lightweight change to
seedso that we always surface the docker logs, regardless of the exit code. This is primarily meant to make it easier to diagnose the behavior of the generator during development, but it can also be used to help us understand the behavior of the generator against real APIs when we run with the--localflag.The new expected
seedoutput looks like the following:Success
Failure
[php-sdk:file-upload]: Running generator... [php-sdk:file-upload]: Started. [php-sdk:file-upload]: Generator logs here: /var/folders/bs/h5sq6ysx2tb_l9dn3tshxcxw0000gn/T/tmp-20608-08ncUDFnEDTA [php-sdk:file-upload]: Docker exited with a non-zero exit code. [php-sdk:file-upload]: Failed.