feat(typescript): Basic Dynamic Snippet Generation for Typescript-v2 #5422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schnides123
requested review from
amckinney
and removed request for
dsinghvi
amckinney
reviewed
Dec 16, 2024
generators/typescript-v2/dynamic-snippets/src/EndpointSnippetGenerator.ts
Show resolved
Hide resolved
Swimburger
reviewed
Dec 17, 2024
generators/typescript-v2/ast/src/ast/__test__/__snapshots__/Function.test.ts.snap
Outdated
Show resolved
Hide resolved
generators/typescript-v2/ast/src/ast/__test__/__snapshots__/Method.test.ts.snap
Outdated
Show resolved
Hide resolved
added rough draft code and tests for functions, parameters, comments, and function invocations for TS-v2. WIP 2: split up methods and subbed snippets code added stubs for snippets, added really rough implementation for methods and implementation for method invocation WIP3: fixed the pascal case fixed pascal case missed one there WIP: it actually runs now snippet generator spits something out, not sure if you can call it typescript tho. still have to work out imports and some other stuff updated param added second write for also printing type
Schnides123
force-pushed
the
feat/dynamic-snippets
branch
from
57c9091 to
cf7e6e5
Compare
2 tasks
# Conflicts: # generators/browser-compatible-base/src/ast/AbstractWriter.ts # generators/typescript-v2/ast/src/ast/Comment.ts # generators/typescript-v2/ast/src/ast/Func.ts # generators/typescript-v2/ast/src/ast/FunctionInvocation.ts # generators/typescript-v2/ast/src/ast/Method.ts # generators/typescript-v2/ast/src/ast/MethodInvocation.ts # generators/typescript-v2/ast/src/ast/Type.ts # generators/typescript-v2/ast/src/ast/__test__/__snapshots__/Function.test.ts.snap # generators/typescript-v2/ast/src/typescript.ts # generators/typescript-v2/dynamic-snippets/src/EndpointSnippetGenerator.ts
Swimburger
reviewed
Dec 18, 2024
Swimburger
previously approved these changes
Dec 18, 2024
# Conflicts: # generators/typescript-v2/ast/src/ast/Function.ts # generators/typescript-v2/ast/src/ast/Method.ts # generators/typescript-v2/ast/src/ast/Type.ts # generators/typescript-v2/ast/src/ast/TypeLiteral.ts # generators/typescript-v2/ast/src/ast/__test__/Function.test.ts # generators/typescript-v2/ast/src/ast/__test__/Method.test.ts # generators/typescript-v2/ast/src/ast/core/AstNode.ts # generators/typescript-v2/dynamic-snippets/src/EndpointSnippetGenerator.ts
Schnides123
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added rough draft code and tests for functions, parameters, comments, and function invocations for TS-v2.
Description
Adds dynamic snippet generation to typescript-v2 generator package
Changes Made
introduces basic endpoint and dynamic snippet generation logic, with basic test coverage
Testing