Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): Add support for non-integer offset pagination #5720

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

amckinney
Copy link
Member

This fixes an issue where offset pagination typed against a non-integer type (e.g. float64) was not initialized correctly. By default, Go will initialize an int with the count := 1 syntax, so we need to explicitly specify the type like:

var count float64 = 1

The remaining functionality is left unchanged.

@amckinney amckinney requested a review from dsinghvi as a code owner January 23, 2025 19:06
@amckinney amckinney merged commit 0a482e6 into main Jan 23, 2025
52 checks passed
@amckinney amckinney deleted the amckinney/go/offset branch January 23, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants