Various fixes #424
Various fixes #424
Conversation
| within a :t:`trait`. | ||
|
|
||
| :dp:`fls_N3cdn4lCZ2Bf` | ||
| An :t:`associated trait implementation item` is an :t:`associated item` that |
There was a problem hiding this comment.
Would it be clearer to write a "trait implementation associated item"? Since the associated item is associated to the trait implementation? Or at least a dash: trait-implementation associated item?
Or is it against the standard (and we would need to change it everywhere!)
There was a problem hiding this comment.
we already have things like associated trait constant and such, so that's where this order comes from
There was a problem hiding this comment.
I understand it as "trait constant" being the main thing, then pre-fixing it with "associated" to be more specific. "trait associated constant" would not flow as well.
There was a problem hiding this comment.
The 3 word terms are ok, it is mostly the 4 word terms that become unclear.
| :std:`core::marker::Sync` :t:`[trait]s`. | ||
| The Rust programming language provides the :std:`core::marker::Send` and | ||
| :std:`core::marker::Sync` :t:`[trait]s` for preventing data races at the | ||
| :t:`type` level. | ||
|
|
There was a problem hiding this comment.
That's more restrictive. Why the change?
There was a problem hiding this comment.
what is more restrictive abou tthis? The main point about this phrasing is to get rid of the possible runtime intepretation from the previous wording. These traits have no runtime implications so care should be taken to word it accordingly
| .. _fls_47xtji9Pk8Lw: | ||
|
|
||
| associated trait implementation item | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Yeah same here, I really think it is clearer to have trait-implementation associated item, at a glance.
| @@ -343,7 +343,7 @@ The following names are used when referring to :t:`[punctuator]s`: | |||
| - Equals | |||
There was a problem hiding this comment.
How are those operators selected, should we have all punctuation?
= assignment
or "//" comment?
There was a problem hiding this comment.
no I don't think we gain anything from adding this for all. The changes here were for completeness sake as the other operators of a similar group have the token names and semantic aliases
| @@ -142,7 +142,8 @@ The :t:`type` of a :t:`static` shall implement the :std:`core::marker::Sized` | |||
| :t:`trait`. | |||
|
|
|||
| :dp:`fls_doi4z6u55bi7` | |||
| A :t:`mutable static` is a :t:`static` whose :t:`value` can be modified. | |||
| A :t:`mutable static` is a :t:`static` with :t:`keyword` ``mut`` whose | |||
There was a problem hiding this comment.
what does global as a term give us
There was a problem hiding this comment.
I thought that it should be specified since it is always global.
|
bors merge |
|
Build succeeded: |
Closes #111
Closes #142
Closes #166
Closes #412