Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify default abi for extern blocks #471

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Specify default abi for extern blocks #471

merged 1 commit into from
Nov 16, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Nov 16, 2023

Fixes #459

pietroalbini
pietroalbini approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

bors-ferrocene bot added a commit that referenced this pull request Nov 16, 2023
@bors-ferrocene @Veykril
Merge #471 #472
36bd2f2 
471: Specify default abi for extern blocks r=pietroalbini a=Veykril

Fixes #459

472: Specify signature compatability requirement for fn ptr coercion r=pietroalbini a=Veykril

Fixes #460

Co-authored-by: Lukas Wirth <[email protected]>
@bors-ferrocene
Copy link
Contributor

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@Veykril
Copy link
Member Author

Veykril commented Nov 16, 2023

bors retry

@bors-ferrocene
Copy link
Contributor

Build succeeded:

@bors-ferrocene bors-ferrocene bot merged commit 46c0959 into main Nov 16, 2023
2 checks passed
@bors-ferrocene bors-ferrocene bot deleted the ext-block-default-abi branch November 16, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietroalbini pietroalbini pietroalbini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default ABI for extern blocks
2 participants
@Veykril @pietroalbini