Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ASI genesis update cmd #341

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

feat: ASI genesis update cmd #341

wants to merge 39 commits into from

Conversation

Jonathansumner
Copy link
Member

@Jonathansumner Jonathansumner commented Apr 9, 2024 •
edited
Loading

Implements intial replace-genesis-values command

  • Sets chain-id to asi-1
  • Enforces and converts addresses to use asi prefix
  • Converts all previous afet/fet-based denominations to aasi, e.g asi, uasi, masi
  • Amends the bridge contract admin to a hard-coded address
  • Withdraws all IBC channel pool balances to a hard-coded address
  • Withdraws all reconciliation address balances to a hard-coded address
    • Reconciliation data is compiled into the binary when building

@Jonathansumner Jonathansumner requested a review from pbukva April 9, 2024 15:53
@Jonathansumner Jonathansumner self-assigned this Apr 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit e2e058e):

https://fetch-docs-preview--pr341-feat-aasi-merger-cmd-jn82mst5.web.app

(expires Sat, 22 Jun 2024 14:46:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2de39fd4e81249941960b74fbab0a62d90d69f8

pbukva
pbukva reviewed Apr 9, 2024
View reviewed changes
cmd/fetchd/cmd/genreplace.go Outdated Show resolved Hide resolved
pbukva
pbukva reviewed Apr 9, 2024
View reviewed changes
cmd/fetchd/cmd/genreplace.go Outdated Show resolved Hide resolved
@Jonathansumner Jonathansumner marked this pull request as ready for review April 19, 2024 15:34
@Jonathansumner Jonathansumner changed the title feat: initial genesis replace cmd feat: genesis replace cmd May 16, 2024
@Jonathansumner Jonathansumner changed the title feat: genesis replace cmd feat: ASI genesis update cmd May 16, 2024
MissingNO57
MissingNO57 reviewed Jun 4, 2024
View reviewed changes
cmd/fetchd/cmd/genesis-asi-upgrade.go
},
IbcTargetAddr: "fetch1zydegef0z6lz4gamamzlnu52ethe8xnm0xe5fkyrgwumsh9pplus5he63f",
ReconciliationInfo: &ReconciliationInfo{
TargetAddress: "fetch1tynmzk68pq6kzawqffrqdhquq475gw9ccmlf9gk24mxjjy6ugl3q70aeyd",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reconciliation contract needs NewAdmin: "fetch15p3rl5aavw9rtu86tna5lgxfkz67zzr6ed4yhw",

Jonathansumner and others added 11 commits June 6, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MissingNO57 MissingNO57 MissingNO57 left review comments

@pbukva pbukva Awaiting requested review from pbukva pbukva is a code owner

@ejfitzgerald ejfitzgerald Awaiting requested review from ejfitzgerald

At least 1 approving review is required to merge this pull request.

Assignees

@Jonathansumner Jonathansumner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jonathansumner @pbukva @MissingNO57