Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add env checks to genesis processor #268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jonathansumner
Copy link
Member

  • Introduces some more robust env checks to the genesis processing entrypoint
    • ensures all necessary envs are present
  • Adds some more helpful print statements
  • Adds genesis-processed db flag to the end of the entrypoint, to avoid flagging success before the script is complete

Code Review Checklist (to be filled out by reviewer)

  • Description accurately reflects what changes are being made.
  • Either the PR references an issue (via the "Development" combobox) or the description explains the need for the changes.
  • The PR appropriately sized.
  • The PR contains an idempotent DB migration.
  • I have verified the correctness of the DB migration using relevant data (e.g. test-generated data).
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

@Jonathansumner Jonathansumner self-assigned this May 17, 2023
@Jonathansumner Jonathansumner changed the title chore: add env checks chore: add env checks to genesis processor May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant