feat(core,example): better support for sending synchronous messages #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrriehl
changed the title
ejfitzgerald
approved these changes
Apr 12, 2024
Dacksus
reviewed
Apr 12, 2024
Archento
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not easy to send a signed synchronous message. Unsigned sync messages can be sent via the
queryfunction inquery.py, but signed sync messages require a lot of extra work.This PR allows sending messages synchronously with
Context.send(..., sync=True)and a standalone functionsend_sync_messagewith a demonstration in the examples.